Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VS 2019 #125

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add support for VS 2019 #125

wants to merge 9 commits into from

Conversation

lewissbaker
Copy link
Owner

No description provided.

@@ -191,6 +191,10 @@ TEST_CASE("Timer cancellation"
}()));
}

// Disable this test under VS 2019.3
// Results in ICE compiling the 'startTimer' lambda below.
#if CPPCORO_COMPILER_MSVC != 192328105
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @GorNishanov I've just been trying to update cppcoro to work with MSVC 2019.3 and have started encountering some new compiler-crashes. I've disabled the problematic tests for now but wanted to give you a heads up.

The base 'Visual Studio 2019' has a later version of the compiler
anyway and the current Preview version has some bugs that caused
runtime crashes on optimised builds.
Copy link

@radzevich radzevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lewissbaker . I switched to this branch and got build failed:

> ./cake.bat release=debug architecture=x64 lib/build.cake

Traceback (most recent call last):
  File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\runner.py", line 454, in run
    configuration = engine.findConfiguration(scriptPath)
  File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\engine.py", line 335, in findConfiguration
    return self.getConfiguration(configScript)
  File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\engine.py", line 308, in getConfiguration
    script.execute()
  File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\tools\cake\src\cake\script.py", line 273, in execute
    exec byteCode in scriptGlobals
  File "C:\Projects\Druniks\Druniks.Prototype\lib\cppcoro\config.cake", line 70, in <module>
    from cake.library.compilers.msvc import getVisualStudioCompiler, findMsvcInstallDir
ImportError: cannot import name getVisualStudioCompiler
Build failed with 1 errors.
Build took 0:00:00.243.

That's because cake submodule targeting clang branch instead of master. Should the submodule branch be also updated in the scope of this PR?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants